Gallardot commented on code in PR #10425:
URL: https://github.com/apache/apisix/pull/10425#discussion_r1401428424


##########
apisix/plugins/forward-auth.lua:
##########
@@ -117,7 +117,8 @@ function _M.access(conf, ctx)
 
     local httpc = http.new()
     httpc:set_timeout(conf.timeout)
-
+    local client_body_reader, err = httpc:get_client_body_reader()
+    params.body=client_body_reader

Review Comment:
   Agree with @monkeyDluffy6017 . Additionally, if this is a GET request, this 
approach may not be appropriate.



##########
apisix/plugins/forward-auth.lua:
##########
@@ -117,7 +117,8 @@ function _M.access(conf, ctx)
 
     local httpc = http.new()
     httpc:set_timeout(conf.timeout)
-
+    local client_body_reader, err = httpc:get_client_body_reader()
+    params.body=client_body_reader

Review Comment:
   Agree with @monkeyDluffy6017 . Additionally, if this is a `GET` request, 
this approach may not be appropriate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to