[GitHub] [apisix] spacewander commented on a change in pull request #2271: bugfix: avoid overwriting Vary header in cors plugin

[GitBox]

spacewander commented on a change in pull request #2271:
URL: https://github.com/apache/apisix/pull/2271#discussion_r495523183



##########
File path: apisix/core/response.lua
##########
@@ -97,19 +103,43 @@ function _M.set_header(...)
             error("should be a table if only one argument", 2)
         end
 
-        for k, v in pairs(headers) do
-            ngx_header[k] = v
+        if append then
+            for k, v in pairs(headers) do
+                ngx_add_header(k, v)
+            end
+
+        else
+            for k, v in pairs(headers) do
+                ngx_header[k] = v
+            end

Review comment:
       @ShiningRush 
   Updated in the new commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org