shreemaan-abhishek commented on code in PR #10425:
URL: https://github.com/apache/apisix/pull/10425#discussion_r1410030305
##########
apisix/plugins/forward-auth.lua:
##########
@@ -106,16 +106,20 @@ function _M.access(conf, ctx)
method = conf.request_method
}
+ local httpc = http.new()
if params.method == "POST" then
params.body = core.request.get_body()
+ local client_body_reader, err = httpc:get_client_body_reader()
+ if not err then
+ params.body = client_body_reader
+ end
Review Comment:
if we go this way other test cases would need to be updated. This might
result in a breaking change for users 🤔
##########
apisix/plugins/forward-auth.lua:
##########
@@ -106,16 +106,20 @@ function _M.access(conf, ctx)
method = conf.request_method
}
+ local httpc = http.new()
if params.method == "POST" then
params.body = core.request.get_body()
+ local client_body_reader, err = httpc:get_client_body_reader()
+ if not err then
+ params.body = client_body_reader
+ end
Review Comment:
if we go this way other test cases would need to be updated. This might
result in a breaking change for users 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
