moonming commented on code in PR #10612:
URL: https://github.com/apache/apisix/pull/10612#discussion_r1418859071


##########
t/plugin/limit-count-redis-cluster.t:
##########
@@ -95,8 +95,7 @@ __DATA__
                             "policy": "redis-cluster",
                             "redis_timeout": 1001,
                             "redis_cluster_nodes": [
-                                "127.0.0.1:5000",
-                                "127.0.0.1:5001"
+                                "127.0.0.1:5000"

Review Comment:
   please add a new test case instead of change old one.
   Better cover example in 
https://github.com/apache/apisix/issues/10596#issuecomment-1844685990, like
   ```
   "limit-count": {
               "redis_cluster_nodes": [
                 "redis-headless-service:6379"
               ],
           }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to