moonming commented on a change in pull request #2333: URL: https://github.com/apache/apisix/pull/2333#discussion_r495651938
########## File path: apisix/core/ctx.lua ########## @@ -96,6 +96,9 @@ do elseif key == "service_id" then val = ngx.ctx.api_ctx and ngx.ctx.api_ctx.service_id + elseif key == "consumer_name" then + val = ngx.ctx.api_ctx and ngx.ctx.api_ctx.consumer_id Review comment: It always confuses me, `name` or `id`? we should choose a good name ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org