starsz commented on code in PR #10905:
URL: https://github.com/apache/apisix/pull/10905#discussion_r1481471895


##########
apisix/control/router.lua:
##########
@@ -198,5 +201,26 @@ end
 
 end -- do
 
+local function reload_plugins()
+    core.log.info("start to hot reload plugins")
+    plugin_mod.load()
+
+    local local_conf = core.config.local_conf()
+    local deployment_role = core.table.try_read_attr(
+                       local_conf, "deployment", "role")
+    if deployment_role ~= "data_plane" then
+        -- data_plane should not write to etcd
+        if ngx_worker_id() == 0 then
+            sync_local_conf_to_etcd()
+        end
+    end

Review Comment:
   The logic is the same as it in the admin API. 
   https://github.com/apache/apisix/blob/master/apisix/admin/init.lua#L469-L475



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to