membphis commented on code in PR #10869:
URL: https://github.com/apache/apisix/pull/10869#discussion_r1482364080
##########
conf/config-default.yaml:
##########
@@ -600,7 +600,9 @@ plugin_attr: # Plugin attributes
# - 100
# - 200
# - 500
- # expire: 86400 # the expiration time after
metrics become inactive, unit: second
+ # expire: 0 # The expiration time after metrics
become inactive, unit: second.
+ # 0 means the metrics will not expire
+ # We recommend using 600 If you need to
set the expiration time
Review Comment:
should avoid to use `we`
How about this:
If you need to set the expiration time, it is recommended to use 600, which
is 10 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
