spacewander commented on a change in pull request #2029:
URL: https://github.com/apache/apisix/pull/2029#discussion_r500713424
##########
File path: apisix/plugin.lua
##########
@@ -228,13 +228,34 @@ function _M.api_routes()
end
-function _M.filter(user_route, plugins)
+local function set_response_header_by_debug_flag(plugins, dry_run)
+ if dry_run then
Review comment:
And to avoid the conflict between global rule / route rule, it would be
better to use `add_header`.
Maybe we still need to pass the `global` flag to indicate if the current
filtering rule is global or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
