membphis commented on a change in pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#discussion_r501548890
##########
File path: apisix/plugins/limit-count.lua
##########
@@ -132,7 +132,9 @@ function _M.check_schema(conf)
end
if conf.policy == "redis-cluster" then
- -- TODO
+ if not conf.redis_serv_list then
+ return false, "missing valid redis option serv_list"
Review comment:
that is a wrong way, we can use JSONSchema to check this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
