shreemaan-abhishek opened a new issue, #11187:
URL: https://github.com/apache/apisix/issues/11187

   ### Description
   
   When internal APISIX code fetches secrets, `has_prefix` check is performed 
twice:
   
[fetch](https://github.com/shreemaan-abhishek/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/secret.lua#L193)
 function does the prefix check:
   - 
https://github.com/apache/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/secret.lua#L200C1-L204C8
   
   Then again `fetch_by_uri` function calls `parse_secret_uri` which calls 
[check_secret_uri](https://github.com/shreemaan-abhishek/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/secret.lua#L133)
 here the check is done again:
   
   
https://github.com/shreemaan-abhishek/apisix/blob/07b3cc3f63db8fc4ae3706baa324a76ee3049338/apisix/secret.lua#L121
   
   ### Caveats:
   
   - the code has multiple layers of abstractions (or rather function calls 
within function calls) each such functions might be a dependency for other part 
of code so this needs to be thoroughly examined first then fixed.
   
   - the above information was just about secret resources containing the 
`$secret://` prefix. Secret resources containing the `$env://` prefix's flow 
also needs to be examined.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to