nic-6443 commented on code in PR #11343: URL: https://github.com/apache/apisix/pull/11343#discussion_r1632205792
########## conf/config-default.yaml: ########## @@ -1,690 +0,0 @@ -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# -# CAUTION: DO NOT MODIFY DEFAULT CONFIGURATIONS IN THIS FILE. -# Keep the custom configurations in conf/config.yaml. -# - -apisix: Review Comment: This file contains explanations for all configuration fields, some of which cannot even be found in the documentation. These comments and commented-out configurations were previously good examples for modifying `config.yaml`. Now, this part of the information is missing in `config.lua`. I am wondering if we can directly use the content from the original `config-default.yaml` as the new `config.yaml`, allowing users to directly modify or remove configurations within it. The `config.lua` will then fill in default values after user updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
