vicaya commented on code in PR #761:
URL: https://github.com/apache/apisix-helm-chart/pull/761#discussion_r1633871008


##########
charts/apisix-ingress-controller/templates/service.yaml:
##########


Review Comment:
   The service change is unnecessary, as the container is embedded in the same 
pod/network namespace. This change exposes the insecure port to the rest of the 
cluster, which is not what you want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to