Re: [PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]

[via GitHub]

zuiyangqingzhou commented on PR #11253:
URL: https://github.com/apache/apisix/pull/11253#issuecomment-2159907808

   > @zuiyangqingzhou you migh wanna fix these first: 😉 
![image](https://private-user-images.githubusercontent.com/61597896/337524047-5d99248c-48e6-4b64-8462-19003ab9892e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgwODc3MjEsIm5iZiI6MTcxODA4NzQyMSwicGF0aCI6Ii82MTU5Nzg5Ni8zMzc1MjQwNDctNWQ5OTI0OGMtNDhlNi00YjY0LTg0NjItMTkwMDNhYjk4OTJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjExVDA2MzAyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk3NzcyMmM4YWNmMmFkMTcwZDY3Njg3OWFmZWM5ZmM1NTA0ZDgzNmFjYjUxYzZhMzc1NTdjNTRmMDMyZmMzYzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eBYy3mvo0SNCimu3YWLsG93nLY6L7cFgDakLrilAaiw)
   
   @shreemaan-abhishek  I just added a sixth test to `t/discovery/nacos2.t`. I 
don't think I caused other file problems such as `t/discovery/nacos.t` and  
`t/discovery/stream/nacos.t`, and the problems in these files are the same.
   
   <img width="827" alt="image" 
src="https://github.com/apache/apisix/assets/17425270/1bd03463-31e4-46ba-9acf-5b890d1e80d7";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org