kayx23 commented on code in PR #2257:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/2257#discussion_r1665519716


##########
docs/en/latest/references/apisix_route_v2.md:
##########
@@ -78,6 +78,7 @@ The table below describes each of the attributes in the spec. 
The fields `apiVer
 | stream[].name                        | string (required)  | Name of the 
rule.                                                                           
                                                                                
              |
 | stream[].match                       | object (required)  | Conditions to 
match the request with the Route.                                               
                                                                                
            |
 | stream[].match.ingressPort           | integer (required) | Listening port 
in the Ingress proxy server. This port should be defined in the [APISIX 
configuration](https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L101).
        |
+| stream[].match.host                  | string             | SNI.        |

Review Comment:
   
https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/apisix/apis/config/v2/types.go#L250
   
   e2e test: 
https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/suite-ingress/suite-ingress-resource/stream.go#L106-L138
   
   <img width="1145" alt="image" 
src="https://github.com/apache/apisix-ingress-controller/assets/39619599/328be728-8bbd-4aab-9d11-32a20f071d21";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to