shreemaan-abhishek commented on code in PR #11445:
URL: https://github.com/apache/apisix/pull/11445#discussion_r1699911150
##########
apisix/plugins/cas-auth.lua:
##########
@@ -87,6 +89,9 @@ local function with_session_id(conf, ctx, session_id)
else
-- refresh the TTL
store:set(session_id, user, SESSION_LIFETIME)
+ if conf.set_user_header then
Review Comment:
the `set_user_header` field is not needed, this feature can be implemented
using the `user_header` field alone. Also please choose a better name to allow
any header to be passed.
eg: field name: `send_headers` and the type of this field should be array,
to allow multiple headers to be sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
