[GitHub] [apisix-dashboard] membphis commented on a change in pull request #551: feature: sync json schema from APISIX and check schema when create or update resource

[GitBox]

membphis commented on a change in pull request #551:
URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503370849



##########
File path: .github/workflows/api_ci.yml
##########
@@ -49,6 +49,16 @@ jobs:
         export GO111MOUDULE=on
         sudo apt install golang-1.14-go
 
+    - name: generate json schema
+      working-directory: ./api
+      run: |
+        wget https://github.com/apache/apisix/archive/master.zip
+        mkdir ./build-tools/apisix/
+        unzip master.zip
+        sudo mv ./apisix-master/apisix/* ./build-tools/apisix/
+        rm -rf ./apisix-master
+        cd ./build-tools/ && lua schema-sync.lua > ../conf/schema.json

Review comment:
       I think we need to check if the `conf/schema.json` is the correct




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org