membphis commented on a change in pull request #2368:
URL: https://github.com/apache/apisix/pull/2368#discussion_r505621566



##########
File path: .travis/linux_specialtest_runner.sh
##########
@@ -34,22 +34,23 @@ create_lua_deps() {
 }
 
 before_install() {
-    sudo cpanm --notest Test::Nginx >build.log 2>&1 || (cat build.log && exit 
1)
-    docker pull redis:3.0-alpine
-    docker run --rm -itd -p 6379:6379 --name apisix_redis redis:3.0-alpine
-    docker run --rm -itd -e HTTP_PORT=8888 -e HTTPS_PORT=9999 -p 8888:8888 -p 
9999:9999 mendhak/http-https-echo
-    # Runs Keycloak version 10.0.2 with inbuilt policies for unit tests
-    docker run --rm -itd -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=123456 -p 
8090:8080 -p 8443:8443 sshniro/keycloak-apisix
-    # spin up kafka cluster for tests (1 zookeper and 1 kafka instance)
-    docker pull bitnami/zookeeper:3.6.0
-    docker pull bitnami/kafka:latest
-    docker network create kafka-net --driver bridge
-    docker run --name zookeeper-server -d -p 2181:2181 --network kafka-net -e 
ALLOW_ANONYMOUS_LOGIN=yes bitnami/zookeeper:3.6.0
-    docker run --name kafka-server1 -d --network kafka-net -e 
ALLOW_PLAINTEXT_LISTENER=yes -e 
KAFKA_CFG_ZOOKEEPER_CONNECT=zookeeper-server:2181 -e 
KAFKA_CFG_ADVERTISED_LISTENERS=PLAINTEXT://127.0.0.1:9092 -p 9092:9092 -e 
KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE=true bitnami/kafka:latest
-    docker pull bitinit/eureka
-    docker run --name eureka -d -p 8761:8761 --env ENVIRONMENT=apisix --env 
spring.application.name=apisix-eureka --env server.port=8761 --env 
eureka.instance.ip-address=127.0.0.1 --env 
eureka.client.registerWithEureka=true --env eureka.client.fetchRegistry=false 
--env eureka.client.serviceUrl.defaultZone=http://127.0.0.1:8761/eureka/ 
bitinit/eureka
-    sleep 5
-    docker exec -i kafka-server1 /opt/bitnami/kafka/bin/kafka-topics.sh 
--create --zookeeper zookeeper-server:2181 --replication-factor 1 --partitions 
1 --topic test2
+    echo "Before install"
+    # sudo cpanm --notest Test::Nginx >build.log 2>&1 || (cat build.log && 
exit 1)

Review comment:
       if we do not need them, we should delete them directly.

##########
File path: .travis/linux_specialtest_runner.sh
##########
@@ -93,34 +94,34 @@ do_install() {
     # sudo apt-get install tree -y
     # tree deps
 
-    git clone https://github.com/iresty/test-nginx.git test-nginx
-    make utils
-
-    git clone https://github.com/apache/openwhisk-utilities.git 
.travis/openwhisk-utilities
-    cp .travis/ASF* .travis/openwhisk-utilities/scancode/
-
-    ls -l ./
-    if [ ! -f "build-cache/grpc_server_example" ]; then
-        wget 
https://github.com/iresty/grpc_server_example/releases/download/20200901/grpc_server_example-amd64.tar.gz
-        tar -xvf grpc_server_example-amd64.tar.gz
-        mv grpc_server_example build-cache/
-    fi
-
-    if [ ! -f "build-cache/proto/helloworld.proto" ]; then
-        if [ ! -f "grpc_server_example/main.go" ]; then
-            git clone https://github.com/iresty/grpc_server_example.git 
grpc_server_example
-        fi
-
-        cd grpc_server_example/
-        mv proto/ ../build-cache/
-        cd ..
-    fi
-
-    if [ ! -f "build-cache/grpcurl" ]; then
-        wget 
https://github.com/api7/grpcurl/releases/download/20200314/grpcurl-amd64.tar.gz
-        tar -xvf grpcurl-amd64.tar.gz
-        mv grpcurl build-cache/
-    fi
+    # git clone https://github.com/iresty/test-nginx.git test-nginx

Review comment:
       dittoo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to