Yilialinn commented on code in PR #11859: URL: https://github.com/apache/apisix/pull/11859#discussion_r1995218449
########## docs/en/latest/plugins/basic-auth.md: ########## @@ -6,7 +6,7 @@ keywords: - Plugin - Basic Auth - basic-auth -description: This document contains information about the Apache APISIX basic-auth Plugin. +description: The basic-auth plugin adds basic access authentication for Consumers to authenticate themselves before being able to access Upstream resources. Review Comment: Capitalize "P" for "plugin" ########## docs/en/latest/plugins/basic-auth.md: ########## @@ -64,91 +70,445 @@ admin_key=$(yq '.deployment.admin.admin_key[0].key' conf/config.yaml | sed 's/"/ ::: +### Implement Basic Authentication on Route + +The following example demonstrates how to implement basic authentication on a route. Review Comment: ```suggestion The following example demonstrates how to implement basic authentication on a Route. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
