nic-6443 commented on code in PR #12048:
URL: https://github.com/apache/apisix/pull/12048#discussion_r2009812263
##########
apisix/plugin.lua:
##########
@@ -506,6 +506,16 @@ function _M.filter(ctx, conf, plugins, route_conf, phase)
if plugin_conf._meta and plugin_conf._meta.priority then
custom_sort = true
end
+
Review Comment:
how about move this check to
https://github.com/apache/apisix/blob/52d8fea3dbc93c4b59ac6682902955c6146af4ad/apisix/plugin.lua#L1184-L1186
as
```
if plugins[i].type == "auth" or (not plugins[i + 1]._from_consumer) then
plugins[i + 1]._skip_rewrite_in_consumer = true
end
```
so that we can keep skip logic in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
