Baoyuantop commented on code in PR #12029:
URL: https://github.com/apache/apisix/pull/12029#discussion_r2018012041
##########
apisix/plugins/chaitin-waf.lua:
##########
@@ -48,8 +52,11 @@ local match_schema = {
local plugin_schema = {
type = "object",
properties = {
- -- TODO: we should add a configuration "mode" here
- -- It can be one of off, block and monitor
+ mode = {
+ type = "string",
+ enum = { "off", "monitor", "block", nil },
+ default = nil,
Review Comment:
This does not affect the use of this feature, which is merged first and then
an issue is created to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
