juzhiyuan commented on code in PR #12224:
URL: https://github.com/apache/apisix/pull/12224#discussion_r2098029310


##########
t/ts/admin_api.ts:
##########
@@ -14,22 +14,29 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import axios, { type Method, type RawAxiosRequestHeaders } from 'axios';
+import axios, {
+  type AxiosRequestConfig,
+  type Method,
+  type RawAxiosRequestHeaders,
+} from 'axios';
 
 export const request = async (
-  uri: string,
+  url: string,
   method: Method = 'GET',
   body?: object,
   headers?: RawAxiosRequestHeaders,
+  config?: AxiosRequestConfig,
 ) => {
   return axios.request({
     method,
     // TODO: use 9180 for admin api
-    url: `http://127.0.0.1:1984/${uri}`,
+    baseURL: 'http://127.0.0.1:1984',
+    url,

Review Comment:
   i can understand this change, but where is it used? 🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to