nic-6443 commented on code in PR #822:
URL: https://github.com/apache/apisix-helm-chart/pull/822#discussion_r2127809083
##########
charts/apisix/values.yaml:
##########
@@ -440,14 +440,20 @@ apisix:
stream: |
- # -- Add custom
[lua_shared_dict](https://github.com/openresty/lua-nginx-module#toc88) settings,
+ # -- Add custom
[lua_shared_dict](https://github.com/openresty/lua-nginx-module?tab=readme-ov-file#lua_shared_dict)
settings,
# click
[here](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L27-L30)
to learn the format of a shared dict
customLuaSharedDicts: []
# - name: foo
# size: 10k
# - name: bar
# size: 1m
+ # -- Override default
[lua_shared_dict](https://github.com/apache/apisix/blob/master/conf/config.yaml.example#L250-L276)
settings,
+ # click
[here](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L27-L30)
to learn the format of a shared dict
+ luaSharedDicts: []
+ # - name: prometheus-metrics
+ # size: 20m
Review Comment:
When the Prometheus plugin is not enabled under the stream subsystem
(default behavior), `http { lua_shared_dict }` is useful:
https://github.com/apache/apisix/blob/58066abc88df37a490f6c04011ed9588a0bda0d1/apisix/cli/ngx_tpl.lua#L329-L331
so this example can be retained.
@dennispan can you fix CI of this PR? you can run `make helm-docs` in your
local and commit changes of docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
