undying commented on code in PR #12187:
URL: https://github.com/apache/apisix/pull/12187#discussion_r2129210171
##########
apisix/upstream.lua:
##########
@@ -297,7 +297,12 @@ function _M.set_by_route(route, api_ctx)
return 503, err
end
- local new_nodes, err = dis.nodes(up_conf.service_name,
up_conf.discovery_args)
+ local service_name, err = core.utils.resolve_var(up_conf.service_name,
api_ctx.var)
+ if not service_name or service_name == "" then
+ return 503, "service_name is empty: " .. (err or "nil")
Review Comment:
Changed the error message for suggested one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
