membphis commented on code in PR #12338:
URL: https://github.com/apache/apisix/pull/12338#discussion_r2158281784
##########
apisix/plugins/kafka-logger.lua:
##########
@@ -140,7 +142,12 @@ local metadata_schema = {
properties = {
log_format = {
type = "object"
- }
+ },
+ max_pending_entries = {
+ type = "integer",
+ description = "maximum number of pending entries in the batch
processor",
+ minimum = 0,
Review Comment:
the minimum should be `1` here
0 is meaningless for APISIX user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
