Copilot commented on code in PR #2427:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2427#discussion_r2167961995
##########
test/e2e/framework/assertion.go:
##########
@@ -116,7 +116,7 @@ func APIv2MustHaveCondition(t testing.TestingT, cli
client.Client, timeout time.
}
err := PollUntilAPIv2MustHaveStatus(cli, timeout, nn, obj, f)
- require.NoError(t, err, "error waiting status to have a Condition
matching %+v", nn, cond)
+ require.NoError(t, err, "error waiting %s status to have a Condition
matching %+v", nn, cond)
Review Comment:
Verify that the format specifier "%s" correctly formats the 'nn' variable.
If 'nn' does not implement Stringer, consider using a different verb (e.g.,
"%+v") to ensure proper formatting.
```suggestion
require.NoError(t, err, "error waiting %+v status to have a Condition
matching %+v", nn, cond)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
