Revolyssup opened a new pull request, #12404:
URL: https://github.com/apache/apisix/pull/12404

   ### Description
   This PR https://github.com/apache/apisix/pull/10589/files, introduced a bug 
due to which the request body is emptied after being read by the auth service 
and the upstream doesn't receive the request body. Therefore, this PR needs to 
be reverted.
   
   The new solution after this revert is accepted will be:
   Do not pass the whole request body to the auth service and extract data from 
body into headers and then forward to the auth service. The headers to be 
extracted will be specified with a new field: `extra_headers`
   
   Fixes https://github.com/apache/apisix/issues/11200
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to