nic-6443 commented on code in PR #12426: URL: https://github.com/apache/apisix/pull/12426#discussion_r2218086250
########## apisix/healthcheck_manager.lua: ########## @@ -0,0 +1,288 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to You under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. +-- +local require = require +local ipairs = ipairs +local pcall = pcall +local exiting = ngx.worker.exiting +local pairs = pairs +local tostring = tostring +local core = require("apisix.core") +local config_local = require("apisix.core.config_local") +local healthcheck +local events = require("apisix.events") +local tab_clone = core.table.clone +local timer_every = ngx.timer.every +local _M = { + working_pool = {}, -- resource_path -> {version = ver, checker = checker} + waiting_pool = {} -- resource_path -> resource_ver +} +local healthcheck_shdict_name = "upstream-healthcheck" +local is_http = ngx.config.subsystem == "http" +if not is_http then + healthcheck_shdict_name = healthcheck_shdict_name .. "-" .. ngx.config.subsystem +end + + +local function get_healthchecker_name(value) + return "upstream#" .. (value.resource_key or value.upstream.resource_key) +end +_M.get_healthchecker_name = get_healthchecker_name + + +local function fetch_latest_conf(resource_path) + local resource_type, id + -- Handle both formats: + -- 1. /apisix/<resource_type>/<id> + -- 2. /<resource_type>/<id> + if resource_path:find("^/apisix/") then + resource_type, id = resource_path:match("^/apisix/([^/]+)/([^/]+)$") + else + resource_type, id = resource_path:match("^/([^/]+)/([^/]+)$") + end + if not resource_type or not id then + core.log.error("invalid resource path: ", resource_path) + return nil + end + + local key + if resource_type == "upstreams" then + key = "/upstreams" + elseif resource_type == "routes" then + key = "/routes" + elseif resource_type == "services" then + key = "/services" + elseif resource_type == "stream_routes" then + key = "/stream_routes" + else + core.log.error("unsupported resource type: ", resource_type) + return nil + end + + local data = core.config.fetch_created_obj(key) + if not data then + core.log.error("failed to fetch configuration for type: ", key) + return nil + end + local resource = data:get(id) + if not resource then + -- this can happen if the resource was deleted + -- after the this function was called so we don't throw error + core.log.warn("resource not found: ", id, " in ", key) + return nil + end + + return resource +end + + +local function create_checker(up_conf) + local local_conf = config_local.local_conf() + if local_conf and local_conf.apisix and local_conf.apisix.disable_upstream_healthcheck then + core.log.info("healthchecker won't be created: disabled upstream healthcheck") + return nil + end + core.log.warn("creating healthchecker for upstream: ", up_conf.resource_key) Review Comment: sure, why still keep it as warn? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
