nic-6443 commented on PR #12457: URL: https://github.com/apache/apisix/pull/12457#issuecomment-3116676881
> I found a breaking change in #12029, the default value of new `mode` field should be `monitor`, otherwise `t/plugin/chaitin-waf-timeout.t` can't be pass. But due to APISIX CI skip some test files incorrectly, CI can't detect this problem in #12029. I have carefully reviewed the current code. This default value behavior should be implemented in the code rather than defined in the JSON schema, because https://github.com/apache/apisix/pull/12029 introduces a `mode` field in both plugin metadata and plugin configuration with the intention of defining two strategies at route and global levels, where the route level can override the global level. If a default value is defined in the JSON schema, this effect cannot be achieved. Therefore, this PR does not need to add a default value to the JSON schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
