nic-6443 commented on code in PR #12465: URL: https://github.com/apache/apisix/pull/12465#discussion_r2238120121
########## apisix/plugins/workflow.lua: ########## @@ -101,10 +101,11 @@ local support_action = { } -function _M.register(plugin_name, handler, check_schema) +function _M.register(plugin_name, handler, check_schema, log_handler) support_action[plugin_name] = { handler = handler, - check_schema = check_schema + check_schema = check_schema, + log_handler = log_handler Review Comment: I think it would be better to adjust the order and naming of this parameter to `check_schema`, `access_handler`, `log_handler`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org