Baoyuantop commented on code in PR #11451: URL: https://github.com/apache/apisix/pull/11451#discussion_r2253885348
########## apisix/plugins/openid-connect.lua: ########## @@ -554,7 +555,7 @@ local function validate_claims_in_oidcauth_response(resp, conf) end function _M.rewrite(plugin_conf, ctx) - local conf = core.table.clone(plugin_conf) + local conf = fetch_secrets(plugin_conf, true, plugin_conf, "") Review Comment: I previously referred to the implementation of other plugin codes: - https://github.com/apache/apisix/blob/master/apisix/plugins/authz-keycloak.lua#L767 - https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count.lua#L37 There are many other locations, so I think there is no problem with the current PR from the implementation point of view. > As soon as someone modifies fetch_secrets in the future and doesn't clone there anymore, something will go wrong with your code. If this happens, many plugin codes will need to be adjusted. If my understanding is wrong, please correct me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
