SkyeYoung commented on code in PR #12448:
URL: https://github.com/apache/apisix/pull/12448#discussion_r2281433313
##########
t/discovery/consul.t:
##########
@@ -781,3 +781,71 @@ location /sleep {
qr//
]
--- ignore_error_log
+
+
+
+=== TEST 16: test metadata_match with consul discovery
Review Comment:
@jizhuozhi I've found a problem. If I understand correctly, the current test
only checks routing to `v2` and `v3`, but it's missing the cases after adding
or removing `metadata_match`. For example, adding `- v4` and removing `- v2`
means the request should only be routed to those marked as `v3` or `v4`.
Maybe I missed something, please trouble you to answer or add the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
