membphis commented on code in PR #12523:
URL: https://github.com/apache/apisix/pull/12523#discussion_r2284702495


##########
apisix/core/config_etcd.lua:
##########
@@ -74,6 +74,7 @@ if not is_http then
 end
 local created_obj  = {}
 local loaded_configuration = {}
+local configuration_loaded_time

Review Comment:
   I can’t sure if we can use Lua global var to cache the value. If I do this, 
will store it in sharedict 
   Pls add test it to confirm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to