SkyeYoung commented on code in PR #12536:
URL: https://github.com/apache/apisix/pull/12536#discussion_r2296522382
##########
apisix/discovery/kubernetes/schema.lua:
##########
@@ -17,7 +17,8 @@
local host_patterns = {
{ pattern = [[^\${[_A-Za-z]([_A-Za-z0-9]*[_A-Za-z])*}$]] },
- { pattern =
[[^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$]] },
+ { pattern = [[^[A-Za-z0-9]([-A-Za-z0-9]*[A-Za-z0-9])?]] ..
Review Comment:
@moonming This document is for object names in Kubernetes, and the API
server endpoint (e.g.,
[`https://5E1D0CEXAMPLEA591B746AFC5AB30262.yl4.us-west-2.eks.amazonaws.com`](https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-resource-eks-cluster.html#:~:text=master%20key%20(CMK).-,Endpoint,as%20https%3A//5E1D0CEXAMPLEA591B746AFC5AB30262.yl4.us%2Dwest%2D2.eks.amazonaws.com.,-Id))
is not a Kubernetes object name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
