Revolyssup commented on code in PR #2550:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2550#discussion_r2334439623
##########
internal/provider/apisix/provider.go:
##########
@@ -80,12 +81,14 @@ func New(updater status.Updater, readier
readiness.ReadinessManager, opts ...pro
}
return &apisixProvider{
- client: cli,
- Options: o,
- translator: &translator.Translator{},
- updater: updater,
- readier: readier,
- syncCh: make(chan struct{}, 1),
+ client: cli,
+ // TODO: Maybe pass port/address from external configuration
+ adcdebugserver: common.NewADCDebugServer(cli.Store,
cli.ConfigManager, 8432),
Review Comment:
I don't think it should be needed to make this port configurable. Maybe we
can hardcode it to some value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
