bzp2010 commented on code in PR #2551:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2551#discussion_r2335633930
##########
api/adc/types.go:
##########
@@ -195,15 +195,14 @@ type Timeout struct {
// +k8s:deepcopy-gen=true
type StreamRoute struct {
- Description string `json:"description,omitempty"`
- ID string `json:"id,omitempty"`
- Labels map[string]string `json:"labels,omitempty"`
- Name string `json:"name"`
- Plugins Plugins `json:"plugins,omitempty"`
- RemoteAddr string `json:"remote_addr,omitempty"`
- ServerAddr string `json:"server_addr,omitempty"`
- ServerPort *int64 `json:"server_port,omitempty"`
- Sni string `json:"sni,omitempty"`
+ Metadata `json:",inline" yaml:",inline"`
+
+ Labels map[string]string `json:"labels,omitempty"`
+ Plugins Plugins `json:"plugins,omitempty"`
+ RemoteAddr string `json:"remote_addr,omitempty"`
+ ServerAddr string `json:"server_addr,omitempty"`
+ ServerPort int32 `json:"server_port,omitempty"`
Review Comment:
If this is a TCP port, it should be `uint16`. Although int32 can cover this
range, it is not strict.
##########
docs/en/latest/reference/api-reference.md:
##########
@@ -1194,7 +1194,7 @@ ApisixRouteStream defines the configuration for a Layer 4
(TCP/UDP) route. Curre
| Field | Description |
| --- | --- |
| `name` _string_ | Name is a unique identifier for the route. This field must
not be empty. |
-| `protocol` _string_ | Protocol specifies the L4 protocol to match. Can be
`tcp` or `udp`. |
+| `protocol` _string_ | Protocol specifies the L4 protocol to match. Can be
`TCP` or `UDP`. |
Review Comment:
Please confirm its compatibility with 1.8.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
