Revolyssup commented on code in PR #2564:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2564#discussion_r2362039223
##########
internal/controller/utils.go:
##########
@@ -428,6 +429,110 @@ func ParseRouteParentRefs(
return gateways, nil
}
+func ParseTCPRouteParentRefs(
Review Comment:
Actually there is some logic difference between parentRef processing for
httproute and tcp route like matching hostnames and such. I first thought to
add a boolean argument to differentiate but that will change function signature
and I was trying to avoid this. Maybe I can make original ParseRouteParentRefs
function generic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
