AlinsRan commented on code in PR #2564:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/2564#discussion_r2366950785


##########
internal/provider/apisix/provider.go:
##########
@@ -108,6 +108,9 @@ func (d *apisixProvider) Update(ctx context.Context, tctx 
*provider.TranslateCon
        case *gatewayv1.HTTPRoute:
                result, err = d.translator.TranslateHTTPRoute(tctx, 
t.DeepCopy())
                resourceTypes = append(resourceTypes, adctypes.TypeService)
+       case *gatewayv1alpha2.TCPRoute:

Review Comment:
   
https://github.com/apache/apisix-ingress-controller/blob/master/internal/controller/gatewayproxy_controller.go#L88
   
   Gatewayproxy will not actively call delete.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to