ronething commented on code in PR #2570:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2570#discussion_r2367141478
##########
api/adc/types.go:
##########
@@ -519,11 +515,13 @@ func ComposeServiceNameWithRule(namespace, name string,
rule string) string {
return buf.String()
}
-func ComposeServiceNameWithStream(namespace, name string, rule string) string {
- // FIXME Use sync.Pool to reuse this buffer if the upstream
- // name composing code path is hot.
+func ComposeGRPCServiceNameWithRule(namespace, name string, rule string)
string {
+ return ComposeServicesNameWithScheme(namespace, name, rule, "grpc")
+}
+
+func ComposeServicesNameWithScheme(namespace, name string, rule string, scheme
string) string {
var p []byte
- plen := len(namespace) + len(name) + 6
+ plen := len(namespace) + len(name) + len(scheme) + 3
Review Comment:
This plen does not contain `rule`, but we have written `rule`. This should
not be the expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
