nic-6443 opened a new pull request, #12632:
URL: https://github.com/apache/apisix/pull/12632

   ### Description
   
   In order for the admin API  standalone mode to work properly in the stream 
subsystem, we need to execute the `apisix.admin` module initialization function 
like in the HTTP subsystem: 
https://github.com/apache/apisix/blob/5e804cf26e4d283a417c40698219ff99ddeda4c4/apisix/admin/standalone.lua#L415-L455.
 The previous test cases called `/apisix/admin/configs` API in a prior test 
case and then test-nginx performed a reload, which led to executing the 
following code and failed to detect that the backend timer was not started 
correctly. 
https://github.com/apache/apisix/blob/5e804cf26e4d283a417c40698219ff99ddeda4c4/apisix/core/config_yaml.lua#L395-L429
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   #### Which issue(s) this PR fixes:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   -->
   Fixes #
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to