Copilot commented on code in PR #2601:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2601#discussion_r2427646438
##########
internal/adc/translator/httproute.go:
##########
@@ -825,3 +833,16 @@ func (t *Translator)
translateHTTPRouteHeaderMatchToVars(header gatewayv1.HTTPHe
}
return HeaderMatchToVars(matchType, string(header.Name), header.Value)
}
+
+func appProtocolToUpstreamScheme(appProtocol string) string {
+ switch appProtocol {
+ case "http":
+ return apiv2.SchemeHTTP
+ case "https":
+ return apiv2.SchemeHTTPS
+ case "kubenetes.io/wss":
Review Comment:
Corrected spelling of 'kubenetes.io/wss' to 'kubernetes.io/wss'.
```suggestion
case "kubernetes.io/wss":
```
##########
internal/adc/translator/apisixroute.go:
##########
@@ -179,13 +179,16 @@ func (t *Translator) addAuthenticationPlugins(rule
apiv2.ApisixRouteHTTP, plugin
}
}
-func (t *Translator) buildRoute(ar *apiv2.ApisixRoute, service *adc.Service,
rule apiv2.ApisixRouteHTTP, plugins adc.Plugins, timeout *adc.Timeout, vars
adc.Vars) {
+func (t *Translator) buildRoute(ar *apiv2.ApisixRoute, service *adc.Service,
rule apiv2.ApisixRouteHTTP, plugins adc.Plugins, timeout *adc.Timeout, vars
adc.Vars, enableWebsocket **bool) {
route := adc.NewDefaultRoute()
route.Name = adc.ComposeRouteName(ar.Namespace, ar.Name, rule.Name)
route.ID = id.GenID(route.Name)
route.Desc = "Created by apisix-ingress-controller, DO NOT modify it
manually"
route.Labels = label.GenLabel(ar)
- route.EnableWebsocket = ptr.To(rule.Websocket)
+ route.EnableWebsocket = rule.Websocket
+ if route.EnableWebsocket == nil && *enableWebsocket != nil {
Review Comment:
Potential nil pointer dereference. The condition should check if
`enableWebsocket != nil` before dereferencing it with `*enableWebsocket != nil`.
```suggestion
if route.EnableWebsocket == nil && enableWebsocket != nil &&
*enableWebsocket != nil {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
