bzp2010 commented on code in PR #12668:
URL: https://github.com/apache/apisix/pull/12668#discussion_r2428142875
##########
apisix/ssl/router/radixtree_sni.lua:
##########
@@ -171,6 +176,33 @@ function _M.match_and_set(api_ctx, match_only, alt_sni)
local sni_rev = sni:reverse()
local ok = radixtree_router:dispatch(sni_rev, nil, api_ctx)
+
+ -- if no SSL matched, try to find a wildcard SSL
Review Comment:
Can't radix trees perform wildcard matching directly? Why do wildcard
matches work fine in our HTTP routes (`/test/*`) and SSL SNI (`*.example.com`)?
In my view, there's no fundamental difference between `*.example.com` and
`*`. If the former works correctly after reverse sort, the latter should also
function out of the box. We shouldn't need to add any special logic for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
