ronething commented on code in PR #2584:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2584#discussion_r2389741435
##########
internal/adc/client/client.go:
##########
@@ -47,22 +47,28 @@ type Client struct {
ConfigManager *common.ConfigManager[types.NamespacedNameKind,
adctypes.Config]
ADCDebugProvider *common.ADCDebugProvider
+
+ log logr.Logger
}
-func New(mode string, timeout time.Duration) (*Client, error) {
+func New(log logr.Logger, mode string, timeout time.Duration) (*Client, error)
{
serverURL := os.Getenv("ADC_SERVER_URL")
if serverURL == "" {
serverURL = defaultHTTPADCExecutorAddr
}
- store := cache.NewStore()
+ store := cache.NewStore(log)
configManager := common.NewConfigManager[types.NamespacedNameKind,
adctypes.Config]()
- log.Infow("using HTTP ADC Executor", zap.String("server_url",
serverURL))
+
+ logger := log.WithName("client")
+ logger.Info("ADC client initialized", zap.String("mode", mode))
Review Comment:
```suggestion
logger.Info("ADC client initialized", "mode", mode)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
