ronething commented on code in PR #2583:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2583#discussion_r2386805865
##########
internal/manager/webhooks.go:
##########
@@ -38,6 +38,15 @@ func setupWebhooks(_ context.Context, mgr manager.Manager)
error {
if err := webhookv1.SetupGatewayProxyWebhookWithManager(mgr); err !=
nil {
return err
}
+ if err := webhookv1.SetupHTTPRouteWebhookWithManager(mgr); err != nil {
+ return err
+ }
+ if err := webhookv1.SetupGRPCRouteWebhookWithManager(mgr); err != nil {
+ return err
+ }
+ if err := webhookv1.SetupTCPRouteWebhookWithManager(mgr); err != nil {
+ return err
+ }
Review Comment:
Yes, but i think we can handle it in the next PR. This PR is getting more
and more inflated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
