Revolyssup commented on issue #12626: URL: https://github.com/apache/apisix/issues/12626#issuecomment-3375652726
Currently there are two sources for which APISIX does plugin validation. [Resources added from admin API.](https://github.com/apache/apisix/blob/742fc4391bb78234608d86fe50460f83d861694c/apisix/admin/routes.lua#L130) [Resources detected from resources.new() (either yaml or etcd) with the checker function.](https://github.com/apache/apisix/blob/742fc4391bb78234608d86fe50460f83d861694c/apisix/http/route.lua#L142) [For admin api, if user tries to add a route/consumer with a plugin that is not enabled we throw the error.](https://github.com/apache/apisix/blob/742fc4391bb78234608d86fe50460f83d861694c/apisix/plugin.lua#L1074) For second case, we silently ignore the error as skip_disabled_plugin is true. 1. Because I don't see any reason to skip the disabled plugin, my proposal is to not skip disabled plugin even in the second case 2. Alternate solution: We still allow for skipping disabled plugin. Just add a warning log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
