This is an automated email from the ASF dual-hosted git repository.

nic443 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
     new ceb95da46 feat: add support for wildcard on SNIs for SSL (#12668)
ceb95da46 is described below

commit ceb95da466b1ab5901565c9f1fdd3ff0f8eeed78
Author: Ashish Tiwari <[email protected]>
AuthorDate: Thu Oct 16 08:31:13 2025 +0530

    feat: add support for wildcard on SNIs for SSL (#12668)
---
 apisix/schema_def.lua               |   2 +-
 apisix/ssl/router/radixtree_sni.lua |   5 +-
 t/stream-node/sni.t                 | 285 ++++++++++++++++++++++++++++++++++++
 3 files changed, 290 insertions(+), 2 deletions(-)

diff --git a/apisix/schema_def.lua b/apisix/schema_def.lua
index cff101007..c13b6bcb1 100644
--- a/apisix/schema_def.lua
+++ b/apisix/schema_def.lua
@@ -39,7 +39,7 @@ local id_schema = {
     }
 }
 
-local host_def_pat = "^\\*?[0-9a-zA-Z-._\\[\\]:]+$"
+local host_def_pat = "^\\*$|^\\*?[0-9a-zA-Z-._\\[\\]:]+$"
 local host_def = {
     type = "string",
     pattern = host_def_pat,
diff --git a/apisix/ssl/router/radixtree_sni.lua 
b/apisix/ssl/router/radixtree_sni.lua
index ae7e5b265..f12be1298 100644
--- a/apisix/ssl/router/radixtree_sni.lua
+++ b/apisix/ssl/router/radixtree_sni.lua
@@ -181,7 +181,10 @@ function _M.match_and_set(api_ctx, match_only, alt_sni)
     end
 
 
-    if type(api_ctx.matched_sni) == "table" then
+    if api_ctx.matched_sni == "*" then
+        -- wildcard matches everything, no need for further validation
+        core.log.info("matched wildcard SSL for SNI: ", sni)
+    elseif type(api_ctx.matched_sni) == "table" then
         local matched = false
         for _, msni in ipairs(api_ctx.matched_sni) do
             if sni_rev == msni or not str_find(sni_rev, ".", #msni) then
diff --git a/t/stream-node/sni.t b/t/stream-node/sni.t
index 41554ba6c..b4f3e28bc 100644
--- a/t/stream-node/sni.t
+++ b/t/stream-node/sni.t
@@ -339,3 +339,288 @@ proxy request to 127.0.0.3:1995
     }
 --- request
 GET /t
+
+
+
+=== TEST 14: set SSL with wildcard * SNI and test route matching
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local t = require("lib.test_admin")
+
+            local ssl_cert = t.read_file("t/certs/apisix.crt")
+            local ssl_key =  t.read_file("t/certs/apisix.key")
+
+            -- Create SSL with wildcard * SNI (catch-all)
+            local data = {
+                cert = ssl_cert,
+                key = ssl_key,
+                sni = "*",  -- Wildcard catch-all
+            }
+
+            local code, body = t.test('/apisix/admin/ssls/100',
+                ngx.HTTP_PUT,
+                core.json.encode(data)
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create wildcard SSL: ", code, " ", body)
+                return
+            end
+
+            -- Create a stream route that will use the wildcard SSL
+            local code, body = t.test('/apisix/admin/stream_routes/100',
+                ngx.HTTP_PUT,
+                [[{
+                    "sni": "unknown-domain.com",
+                    "upstream": {
+                        "nodes": {
+                            "127.0.0.1:1995": 1
+                        },
+                        "type": "roundrobin"
+                    }
+                }]]
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create stream route: ", code, " ", body)
+                return
+            end
+
+            ngx.say("passed")
+        }
+    }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 15: hit route with unknown domain using wildcard SSL
+--- stream_tls_request
+mmm
+--- stream_sni: unknown-domain.com
+--- response_body
+hello world
+--- error_log
+proxy request to 127.0.0.1:1995
+
+
+
+=== TEST 16: test SSL priority - exact match over partial wildcard
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local t = require("lib.test_admin")
+
+            local ssl_cert = t.read_file("t/certs/apisix.crt")
+            local ssl_key =  t.read_file("t/certs/apisix.key")
+
+            -- Create SSL with exact domain match
+            local data = {
+                cert = ssl_cert,
+                key = ssl_key,
+                sni = "specific.api7.dev",
+            }
+
+            local code, body = t.test('/apisix/admin/ssls/101',
+                ngx.HTTP_PUT,
+                core.json.encode(data)
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create exact SSL: ", code, " ", body)
+                return
+            end
+
+            -- Create SSL with partial wildcard
+            local data = {
+                cert = ssl_cert,
+                key = ssl_key,
+                sni = "*.api7.dev",
+            }
+
+            local code, body = t.test('/apisix/admin/ssls/102',
+                ngx.HTTP_PUT,
+                core.json.encode(data)
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create partial wildcard SSL: ", code, " ", 
body)
+                return
+            end
+
+            -- Create routes for testing
+            local code, body = t.test('/apisix/admin/stream_routes/101',
+                ngx.HTTP_PUT,
+                [[{
+                    "sni": "specific.api7.dev",
+                    "upstream": {
+                        "nodes": {
+                            "127.0.0.1:1995": 1
+                        },
+                        "type": "roundrobin"
+                    }
+                }]]
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create exact route: ", code, " ", body)
+                return
+            end
+
+            local code, body = t.test('/apisix/admin/stream_routes/102',
+                ngx.HTTP_PUT,
+                [[{
+                    "sni": "*.api7.dev",
+                    "upstream": {
+                        "nodes": {
+                            "127.0.0.2:1995": 1
+                        },
+                        "type": "roundrobin"
+                    }
+                }]]
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create partial wildcard route: ", code, " 
", body)
+                return
+            end
+
+            ngx.say("passed")
+        }
+    }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 17: verify exact domain takes priority over partial wildcard
+--- stream_tls_request
+mmm
+--- stream_sni: specific.api7.dev
+--- response_body
+hello world
+--- error_log
+proxy request to 127.0.0.1:1995
+--- no_error_log
+proxy request to 127.0.0.2:1995
+
+
+
+=== TEST 18: test SSL priority - partial match over wildcard
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local t = require("lib.test_admin")
+
+            local ssl_cert = t.read_file("t/certs/apisix.crt")
+            local ssl_key =  t.read_file("t/certs/apisix.key")
+
+            -- Create SSL with partial domain match
+            local data = {
+                cert = ssl_cert,
+                key = ssl_key,
+                sni = "specific.api7.dev",
+            }
+
+            local code, body = t.test('/apisix/admin/ssls/101',
+                ngx.HTTP_PUT,
+                core.json.encode(data)
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create exact SSL: ", code, " ", body)
+                return
+            end
+
+            -- Create SSL with wildcard
+            local data = {
+                cert = ssl_cert,
+                key = ssl_key,
+                sni = "*",
+            }
+
+            local code, body = t.test('/apisix/admin/ssls/102',
+                ngx.HTTP_PUT,
+                core.json.encode(data)
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create partial wildcard SSL: ", code, " ", 
body)
+                return
+            end
+
+            -- Create routes for testing
+            local code, body = t.test('/apisix/admin/stream_routes/101',
+                ngx.HTTP_PUT,
+                [[{
+                    "sni": "*.api7.dev",
+                    "upstream": {
+                        "nodes": {
+                            "127.0.0.1:1995": 1
+                        },
+                        "type": "roundrobin"
+                    }
+                }]]
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create exact route: ", code, " ", body)
+                return
+            end
+
+            local code, body = t.test('/apisix/admin/stream_routes/102',
+                ngx.HTTP_PUT,
+                [[{
+                    "sni": "*",
+                    "upstream": {
+                        "nodes": {
+                            "127.0.0.2:1995": 1
+                        },
+                        "type": "roundrobin"
+                    }
+                }]]
+            )
+
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("failed to create partial wildcard route: ", code, " 
", body)
+                return
+            end
+
+            ngx.say("passed")
+        }
+    }
+--- request
+GET /t
+--- response_body
+passed
+
+
+
+=== TEST 19: verify partial match takes priority over wildcard
+--- stream_tls_request
+mmm
+--- stream_sni: specific.api7.dev
+--- response_body
+hello world
+--- error_log
+proxy request to 127.0.0.1:1995
+--- no_error_log
+proxy request to 127.0.0.2:1995

Reply via email to