SkyeYoung commented on code in PR #3229:
URL: https://github.com/apache/apisix-dashboard/pull/3229#discussion_r2434929220
##########
.github/workflows/e2e.yml:
##########
@@ -72,14 +72,13 @@ jobs:
- name: Waiting dashboard service to be healthy
working-directory: ./e2e/server
run: |
- E2E_SERVER="dashboard-e2e"
TIMEOUT=30
timeout $TIMEOUT bash -c '
- until [ "$(docker inspect --format="{{.State.Health.Status}}"
$(docker compose ps -q '$E2E_SERVER'))" = "healthy" ]; do
- echo "'$E2E_SERVER' is starting..."
+ until curl -f http://127.0.0.1:9180/ui > /dev/null 2>&1; do
+ echo "Waiting for APISIX dashboard to be ready..."
sleep 5
done
- ' || (echo "$E2E_SERVER not healthy after $TIMEOUT seconds" && exit
1)
+ ' || (echo "APISIX dashboard not ready after $TIMEOUT seconds" &&
exit 1)
Review Comment:
When removing the original e2e server, the healthcheck was removed and
replaced with a more direct way to detect whether the dashboard can be accessed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
