DSingh0304 opened a new pull request, #3245:
URL: https://github.com/apache/apisix-dashboard/pull/3245
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
This PR adds comprehensive E2E tests for the Secrets resource, covering all
CRUD operations and list page functionality.
**Test Coverage (11 tests, all passing ✅):**
- **List page tests** (`secrets.list.spec.ts`) - 3 tests
- Navigation to secrets page
- Pagination using table controls
- Pagination using URL search parameters
- **CRUD with required fields** (`secrets.crud-required-fields.spec.ts`) - 4
tests
- Uses Vault manager with only required fields (id, uri, prefix, token)
- Tests create, read, update, and delete operations
- **CRUD with all fields** (`secrets.crud-all-fields.spec.ts`) - 4 tests
- Uses AWS manager with all fields including optional ones (session_token,
region, endpoint_url)
- Tests create, read, update, and delete operations
**Files Added:**
- `e2e/pom/secrets.ts` - Page Object Model with navigation helpers and
assertions
- `e2e/tests/secrets.list.spec.ts` - List page and pagination tests
- `e2e/tests/secrets.crud-required-fields.spec.ts` - Vault manager CRUD tests
- `e2e/tests/secrets.crud-all-fields.spec.ts` - AWS manager CRUD tests
**Implementation Details:**
- Tests use API-based operations for create/update/delete (following the
pattern of other resources)
- Proper handling of secret ID format (`manager/id`)
- Type-safe assertions using TypeScript discriminated unions
- Serial test execution to prevent conflicts
- Validates all three secret manager types are supported: vault, aws, gcp
**Related issues**
resolve #3091
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features
have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document? (N/A - E2E tests don't
require documentation updates)
- [x] Is this PR backward compatible? If it is not backward compatible,
please discuss on the mailing list first (Yes, only adds tests, no breaking
changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
