AlinsRan commented on code in PR #2647:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2647#discussion_r2526061518
##########
config/crd/bases/apisix.apache.org_gatewayproxies.yaml:
##########
@@ -150,6 +155,9 @@ spec:
type: object
x-kubernetes-validations:
- rule: has(self.endpoints) != has(self.service)
+ - message: mode is immutable
+ rule: oldSelf == null || (!has(self.mode) &&
!has(oldSelf.mode))
+ || self.mode == oldSelf.mode
Review Comment:
1. The main conservative consideration is to avoid unforeseen consequences
by adding this restriction.
2. Because ADC has memory status, switching to the same cached key mode may
affect the memory results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
