qihaiyan commented on code in PR #12706: URL: https://github.com/apache/apisix/pull/12706#discussion_r2548675438
########## t/cli/test_prometheus_stream.sh: ########## @@ -60,7 +60,7 @@ sleep 1 # wait for sync out="$(curl http://127.0.0.1:9091/apisix/prometheus/metrics)" if ! echo "$out" | grep "apisix_stream_connection_total{route=\"1\"} 1" > /dev/null; then - echo "failed: prometheus can't work in stream subsystem" + echo "failed: prometheus can't work in both http & stream subsystem" Review Comment: I didn't find out how to set use_apisix_base=false in ut environment, it's setted in env.lua: ``` local use_apisix_base = true if not or_info:find("apisix-nginx-module", 1, true) then use_apisix_base = false end ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
