ngclinflows commented on code in PR #900:
URL: https://github.com/apache/apisix-helm-chart/pull/900#discussion_r2560217358
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -58,7 +58,9 @@ data:
{{- if or .Values.apisix.customPlugins.enabled
.Values.apisix.luaModuleHook.enabled }}
extra_lua_path: {{ .Values.apisix.customPlugins.luaPath }};{{
.Values.apisix.luaModuleHook.luaPath }}
{{- end }}
-
+
+ trusted_addresses: {{ toYaml .Values.apisix.trusted_addresses | nindent
8 }}
Review Comment:
Don't forget to add an empty default value and some
description/documentation in the `values.yaml` file.
Also, try to follow Helm naming conventions for values (camelCase instead of
snake_case): change it to `trustedAddresses`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
